Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run shellcheck in a one-liner #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link

@netlify
Copy link

netlify bot commented Jul 9, 2022

👷 Deploy request for kodiak-dashboard-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fc1a68c

@netlify
Copy link

netlify bot commented Jul 9, 2022

👷 Deploy request for kodiak-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fc1a68c

@szepeviktor
Copy link
Author

If it works the local shell script could be deleted.

@@ -407,7 +407,7 @@ jobs:
- run:
name: run shellcheck
command: |
./s/shellcheck
git ls-files --exclude='*.sh' --ignored --cached -z | xargs -0 -r shellcheck
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the s/shellcheck script so we can run this check locally

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have to face that I'm not a developer, and unable to sympathize 😿

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this one-liner to s/shellcheck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants