fix: avoid setting ssl_certificate and remove it from tests #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -280,13 +280,12 @@ func resourceCheck() *schema.Resource { | |||
| "ssl_certificates": { | |||
| Type: schema.TypeSet, | |||
| Optional: true, | |||
| Deprecated: "The property `ssl_certificates` is deprecated and it's ignored by the Checkly Public API. It will be removed in a future version.", | |||
| Deprecated: "This property is deprecated and it's ignored by the Checkly Public API. It will be removed in a future version.", | |||
There was a problem hiding this comment.
This change sadly makes it ambiguous which argument has been deprecated. Really Terraform should be dealing with this nicer, so I've raised an issue upstream: hashicorp/terraform-plugin-sdk#1094
There was a problem hiding this comment.
@RealOrangeOne thanks for the feedback, do you think we can make something for now to improve the DX and make it clear?
There was a problem hiding this comment.
I guess the original message was better than the new one for user understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Pre-Requisites
terraform fmtgo fmtplan&applycommand ofdemo/main.tffile do not produce diffsNotes for the Reviewer
ssl_certificatesproperty