test/check-size: show error if make fails #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 80.31% 80.56% +0.25%
==========================================
Files 3 3
Lines 386 391 +5
==========================================
+ Hits 310 315 +5
Misses 55 55
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This patch adds an error message when compilation fails when running the check-size script. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git
force-pushed
the
check-size-error-msg
branch
from
4f51af5
to
035d8f1
Compare
snprajwal
reviewed
Jun 8, 2023
By default, the SHA that is checked out is a merge commit from the base branch on the PR. To use the PR HEAD instead of this merge commit, we need to explicitly specify the SHA from the event context provided by GitHub. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
snprajwal
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an error message when compilation fails when running the
check-size.shscript.