ci: enable tests with go 1.19.x #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains auto-generated changes with the following command:
gofmt -w -s ./*/*.go
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 51.38% 51.38%
=======================================
Files 2 2
Lines 288 288
=======================================
Hits 148 148
Misses 105 105
Partials 35 35 Help us with your feedback. Take ten seconds to tell us how you rate us. |
The verify / lint CI workflow running golangci-lint currently fails with: phaul/api.go:30: File is not `gofmt`-ed with `-s` (gofmt) //Methods: phaul/server.go:37: File is not `gofmt`-ed with `-s` (gofmt) // The problem occurs because, for some reason, golangci-lint is using gofmt from go 1.19. In a previous patch the code has been formatted with go 1.19. This patch enables the CI tests to run with go 1.19.X. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
adrianreber
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verify / lint CI workflow running
golangci-lintcurrently fails with:This problem has been reported in golangci/golangci-lint-action#535
The problem occurs because, for some reason, golangci-lint is using
gofmtfrom go 1.19. This pull request formats the code using gofmt and enables the CI tests to run with go 1.19.