Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for running checkstyle #691

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Bananeweizen
Copy link
Collaborator

This adds a command for the already existing action to run checkstyle on the selected resources. That way users can invoke the command also via Ctrl-3 quick assist or via a key binding.

There is no default key binding, as the normal workflow for users is to rely on the Eclipse builder and to not invoke this command manually.

fixes #99

grafik

Be aware the shown keybinding is not available by default. I just added that for testing and to illustrate that a keybinding can be given by the user.

This adds a command for the already existing action to run checkstyle on
the selected resources. That way users can invoke the command also via
Ctrl-3 quick assist or via a key binding.

There is no default key binding, as the normal workflow for users is to
rely on the Eclipse builder and to not invoke this command manually.

fixes checkstyle#99
@Bananeweizen Bananeweizen merged commit c990680 into checkstyle:master Jun 2, 2024
7 checks passed
@Bananeweizen Bananeweizen deleted the command branch June 2, 2024 18:45
@romani
Copy link
Member

romani commented Jun 2, 2024

@Bananeweizen , please do not merge your own PRs , please wait for review from someone else.
PR is opportunity for others to understand details on how it works and ask questions.
We should avoid code that only single person understands.

If PR is hanging for long without review, pin me or @rnveach , we will merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing keybinding for "Check Code with CheckStyle" command
2 participants