Fix bug in catch-all routes with SSG (vercel#10379)

* Fix bug in catch-all routes with SSG * fix slash Co-authored-by: Joe Haddad <timer150@gmail.com>
chibicode · Feb 11, 2020 · 3bda7b8 · 3bda7b8
1 parent 34f51c0
commit 3bda7b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/next/build/utils.ts b/packages/next/build/utils.ts
@@ -592,11 +592,9 @@ export async function isPageStatic(
 
             builtPage = builtPage.replace(
               `[${repeat ? '...' : ''}${validParamKey}]`,
-              encodeURIComponent(
-                repeat
-                  ? (paramValue as string[]).join('/')
-                  : (paramValue as string)
-              )
+              repeat
+                ? (paramValue as string[]).map(encodeURIComponent).join('/')
+                : encodeURIComponent(paramValue as string)
             )
           })
 

diff --git a/test/integration/prerender/test/index.test.js b/test/integration/prerender/test/index.test.js
@@ -109,8 +109,8 @@ const expectedManifestRoutes = () => ({
     initialRevalidateSeconds: false,
     srcRoute: null,
   },
-  '/catchall/another%2Fvalue': {
-    dataRoute: `/_next/data/${buildId}/catchall/another%2Fvalue.json`,
+  '/catchall/another/value': {
+    dataRoute: `/_next/data/${buildId}/catchall/another/value.json`,
     initialRevalidateSeconds: 1,
     srcRoute: '/catchall/[...slug]',
   },