Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pathFilter option [BREAKING CHANGE] #722

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Feb 27, 2022

Description

Removes old "context" , add it back as option.pathFilter (matching functionality did not change)

Before:

createProxyMiddleware('/api', { target: 'http://www.example.org' });

After:

createProxyMiddleware({
  pathFilter: '/api',
  target: 'http://www.example.org',
});

Motivation and Context

  • simplify internal code
  • simplify public api

How has this been tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chimurai chimurai changed the base branch from master to v3 February 27, 2022 09:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 98.795% when pulling 12ba812 on path-filter-option into 1540dac on v3.

@chimurai chimurai added this to the v3.0.0 milestone Feb 27, 2022
@chimurai chimurai changed the title feat: pathFilter option feat: pathFilter option [BREAKING CHANGE] Feb 27, 2022
@chimurai chimurai merged commit 0b30c5d into v3 Feb 27, 2022
@chimurai chimurai deleted the path-filter-option branch February 27, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants