Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate X509 and Crypto logic #1409

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Deduplicate X509 and Crypto logic #1409

wants to merge 1 commit into from

Conversation

sree-revoori1
Copy link
Contributor

There is a lot of shared X509 and Crypto logic between FMC and ROM. Refactor all of this into common so it can be shared.

fixes #1408

@sree-revoori1
Deduplicate X509 and Crypto logic
ba40503 
There is a lot of shared X509 and Crypto logic between FMC
and ROM. Refactor all of this into common so it can be shared.
vsonims
vsonims requested changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@vsonims vsonims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this kind of refactoring really needed for 1.0 or can it wait for 2.0?

@korran
Copy link
Collaborator

korran commented Mar 18, 2024 •
edited

Is this kind of refactoring really needed for 1.0 or can it wait for 2.0?

@sree-revoori1, let's hold off on merging this until after rom-1.1 is branched off in a few weeks.

@sree-revoori1
Copy link
Contributor Author

sree-revoori1 commented Mar 18, 2024 •
edited

@korran @vsonims Sounds good, I will mark it as a draft until then.

@sree-revoori1 sree-revoori1 marked this pull request as draft March 18, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsonims vsonims vsonims requested changes

@jhand2 jhand2 Awaiting requested review from jhand2 jhand2 is a code owner

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@FerralCoder FerralCoder Awaiting requested review from FerralCoder FerralCoder is a code owner

@mhatrevi mhatrevi Awaiting requested review from mhatrevi mhatrevi is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@jlmahowa-amd jlmahowa-amd Awaiting requested review from jlmahowa-amd jlmahowa-amd is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deduplicate crypto and x509 functions
3 participants
@sree-revoori1 @korran @vsonims