Skip to content

Commit

Permalink
compose: Cut animation on mention-unsubscribed warning.
Browse files Browse the repository at this point in the history
This animation looks kind of odd, and inappropriate for the entrance
of a banner.  See description here:
  zulip#4101 (comment)

Ideally we'd have an appropriate animation, like the banner sliding
in from the bottom.  But no animation at all actually looks pretty OK
to me here, and definitely better than this odd animation.

(We use the same odd animation for the "N unreads" banner, and it's
equally inappropriate there.  Likely we should just drop it there, too.)
  • Loading branch information
gnprice committed Aug 11, 2020
1 parent 6cf3114 commit 7a23ac7
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/compose/MentionWarnings.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { isPrivateNarrow } from '../utils/narrow';
import * as api from '../api';
import { showToast } from '../utils/info';

import AnimatedScaleComponent from '../animation/AnimatedScaleComponent';
import MentionedUserNotSubscribed from '../message/MentionedUserNotSubscribed';

type State = {|
Expand Down Expand Up @@ -162,11 +161,7 @@ class MentionWarnings extends PureComponent<Props, State> {
);
}

return (
<AnimatedScaleComponent visible={mentionWarnings.length !== 0}>
{mentionWarnings}
</AnimatedScaleComponent>
);
return mentionWarnings;
}
}

Expand Down

0 comments on commit 7a23ac7

Please sign in to comment.