Add Canvas settings URL #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrrowland
added a commit
that referenced
this pull request
Aug 9, 2021
* Wire up get course sections w/ create sections FE * Wire up adding sections * Handle error display * File name alignment fix * File name alignment fix * Refactor flow. Apply context free validation on file upload. Apply validation requiring awareness of server data on submit. * Uncoment a thus far unused property * Update ccm_web/client/src/api.ts Co-authored-by: Mr. Lance E Sloan «UMich» <lsloan-github.com@umich.edu> * Non functional tweaking of getPost getPut * Delete the forbidden comment * Reorder some imports ~asthetics~ * Remove an unused css style * rename a variable * Only change to LoadingExistingSectionNamesFailed if getCanvasSectionDataError is defined * Prevent multiple submits * Update ccm_web/client/src/pages/BulkSectionCreate.tsx Suggested formatting change Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com> * Update ccm_web/client/src/pages/BulkSectionCreate.tsx Suggested formatting change Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com> * Update ccm_web/client/src/pages/BulkSectionCreate.tsx Fix alert text Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com> * Escape quotes in text * Learning to spell basic words * Get rid of redundant code. Need to get better at javascript * Add Canvas settings URL (#3) * Send Canvas URL in /api/globals; wire up BulkSectionCreate to use it for settings link * Use Link component; add target _parent Co-authored-by: Mr. Lance E Sloan «UMich» <lsloan-github.com@umich.edu> Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration to be included in tl-its-umich-edu#164.