Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[report problem] undedupe yarn 3 package #3

Draft
wants to merge 1 commit into
base: yarn-berry
Choose a base branch
from

Conversation

fcollonval
Copy link

Hey,

As this is a fork, I unfortunately cannot open an issue. So using a fake PR for it.

Thanks a lot for this - it helps us a lot on the large repo jupyterlab.

When running this tool, there seems to be one dependency specification that get considered as different version although yarn v3 is actually deduping them. This is an example of undeduplication that this script is applying on the jupyterlab yarn.lock:

image

It happens for another package "string-width-cjs@npm:string-width@^4.2.0". So it seems that that specification of version is not correctly handle.

Could we help fix this as it renders the --fail option useless in our CI job?

@reviewflow
Copy link

reviewflow bot commented Jul 17, 2023

Progress

🟡 Step 1: ✏️ Write code
🔴 Step 2: 💚 Checks
⬜ Step 3: 👌 Code Review
⬜ Step 4: 🚦 Merge Pull Request

Infos:

Pull Request's title does not match conventional commit:
❌ subject may not be empty
❌ type may not be empty

Options:

  • 🚦 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.
  • ♻️ Automatically delete the branch after this PR is merged. (⚠️ Legacy Option: Delete branch with Github Setting)

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@reviewflow reviewflow bot added the 💚 checks/fail Synced by reviewflow for checks/failed label Jul 17, 2023
@manoraj
Copy link

manoraj commented Mar 19, 2024

Similar issue for the latest tag. Though yarn dedupes correctly when the latest tag matches with the resolved version, deduping with this tool will create the separate entry in the lock file

Screenshot 2024-03-19 at 10 00 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 checks/fail Synced by reviewflow for checks/failed
Projects
None yet
2 participants