Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): include ctx-shared in package files #1

Closed

Conversation

chriszs
Copy link
Owner

@chriszs chriszs commented Mar 19, 2024

Why

Fixes the failure documented in expo#27740 wherein typed route generation failed to find an import called ctx-shared in the Expo Router canary package.

How

Includes the ctx-shared.js file used by typed route generation in the expo-router package files by adding it to the explicit list of included files in package.json.

Test Plan

To test I started with my minimal reproduction (in which npm start fails), downloaded ctx-shared.js, moved it into node_modules/expo-router/ and then ran npm start again (successfully).

Fixes an issue where typed routes would fail to generate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant