Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTA: Fix tooltip spacing #219

Merged
merged 4 commits into from Mar 20, 2024
Merged

VTA: Fix tooltip spacing #219

merged 4 commits into from Mar 20, 2024

Conversation

MichaelArestad
Copy link
Contributor

All I am doing is removing a little margin from the tooltip.

@MichaelArestad MichaelArestad added enhancement Classification: Improvement to existing feature skip-release Auto: Preserve the current version when merged labels Mar 13, 2024
@MichaelArestad MichaelArestad self-assigned this Mar 13, 2024
@MichaelArestad MichaelArestad added the patch Auto: Increment the patch version when merged label Mar 13, 2024
thafryer
thafryer approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine!

ghengeveld
ghengeveld approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping the name TooltipNote because that's what it's based on.

@MichaelArestad MichaelArestad marked this pull request as ready for review March 20, 2024 15:39
@MichaelArestad
Copy link
Contributor Author

MichaelArestad commented Mar 20, 2024 •
edited

I would prefer keeping the name TooltipNote because that's what it's based on.

@ghengeveld Good call. I changed it to TooltipNote. This should be ready to go now once tests are done.

@MichaelArestad MichaelArestad added release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels Mar 20, 2024
@MichaelArestad MichaelArestad merged commit 7bf72cf into main Mar 20, 2024
10 checks passed
@MichaelArestad MichaelArestad deleted the fix/tooltip-spacing branch March 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

@thafryer thafryer thafryer approved these changes

Assignees

@MichaelArestad MichaelArestad

Labels
enhancement Classification: Improvement to existing feature patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelArestad @ghengeveld @thafryer