Fix misbehaving in rendering when addon is not active #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
release
…ing them when switching panel tabs
ghengeveld
approved these changes
Apr 4, 2024
ghengeveld
added
skip-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addon was rendering even when it was not supposed to, as can be seen here:
The Storybook addon API contains a flag to indicate whether the addon is actively selected, so we use it in order to not render it when not needed
CAVEAT
There is a side effect where the addon is not rendering instantly as before when switching tabs. It displays a spinner. We should check how to find a middle ground for this
📦 Published PR as canary version:
1.2.27--canary.272.30610d6.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.2.27--canary.272.30610d6.0 # or yarn add @chromatic-com/storybook@1.2.27--canary.272.30610d6.0