generated from storybookjs/addon-kit
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save local state in sessionStorage
or shared state
#274
Merged
ghengeveld
merged 15 commits into
main
from
ghengeveld/273-state-is-lost-when-switching-to-docs-page
Apr 4, 2024
Merged
Save local state in sessionStorage
or shared state
#274
ghengeveld
merged 15 commits into
main
from
ghengeveld/273-state-is-lost-when-switching-to-docs-page
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
release
Auto: Create a `latest` release when merged
patch
Auto: Increment the patch version when merged
labels
Mar 27, 2024
ghengeveld
changed the title
Sync local state with sessionStorage to avoid losing it when addon is closed
Save local state in Mar 27, 2024
sessionStorage
…as well, and better handle (de)serialization
ghengeveld
changed the title
Save local state in
Save local state in Mar 28, 2024
sessionStorage
sessionStorage
or shared state
ndelangen
approved these changes
Apr 2, 2024
ghengeveld
deleted the
ghengeveld/273-state-is-lost-when-switching-to-docs-page
branch
April 4, 2024 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching to a docs page, addons don't render and thus the VTA addon is destroyed, losing all internal React state. By synchronizing local state with sessionStorage, this problem is circumvented.
📦 Published PR as canary version:
1.3.0--canary.274.0843e22.0
✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.3.0--canary.274.0843e22.0 # or yarn add @chromatic-com/storybook@1.3.0--canary.274.0843e22.0