Deeply reset the build progress when starting a new build #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
release
ndelangen
approved these changes
Apr 5, 2024
ghengeveld
deleted the
ghengeveld/252-build-progress-reporting-broken-on-second-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
The
localBuildProgressvalue is mutated during the build, which was affectingINITIAL_BUILD_PAYLOADcausing subsequent builds to think steps had already been completed. By ensuring a clean initial value each time, this issue is avoided.I could've avoided the mutation itself, but that would've been a brittle fix prone to regression.
📦 Published PR as canary version:
1.3.1--canary.284.bf6291a.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.3.1--canary.284.bf6291a.0 # or yarn add @chromatic-com/storybook@1.3.1--canary.284.bf6291a.0