Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Switch to use pnpm #5

Merged
merged 8 commits into from Jun 15, 2023
Merged

Build: Switch to use pnpm #5

merged 8 commits into from Jun 15, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 14, 2023

The yarn lockfile seems near corruption somehow.
Could switch to yarn berry, or just take the dive into the future.

📦 Published PR as canary version: 0.0.4-canary.5.b0b42b9.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.4-canary.5.b0b42b9.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.4-canary.5.b0b42b9.0

@ndelangen ndelangen requested a review from weeksling June 14, 2023 20:05
@ndelangen ndelangen self-assigned this Jun 14, 2023
@ndelangen
Copy link
Member Author

Someone should go visit the design-system packages and fix this:

└─┬ @storybook/design-system 7.15.11
  ├── ✕ unmet peer react@"^15.0.0 || ^16.0.0 || ^17.0.0": found 18.0.0
  ├── ✕ unmet peer react-dom@"^15.0.0 || ^16.0.0 || ^17.0.0": found 18.0.0
  └─┬ react-popper-tooltip 2.11.1
    ├── ✕ unmet peer react@^16.6.0: found 18.0.0
    ├── ✕ unmet peer react-dom@^16.6.0: found 18.0.0
    └─┬ react-popper 1.3.11
      └── ✕ unmet peer react@"0.14.x || ^15.0.0 || ^16.0.0 || ^17.0.0": found 18.0.0

@ndelangen
Copy link
Member Author

This PR is not strictly necessary anymore if storybookjs/storybook#23080 lands and works as expected, but I'd propose still moving forward with it.. pnpm is a great package manager.

I understand it's annoying to have to run pnpm run XYZ instead of yarn XYZ, there's a lot of muscle-memory to overcome.

@weeksling weeksling merged commit b0b42b9 into main Jun 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants