Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated npm script misses -b option #268

Closed
bodograumann opened this issue Jan 29, 2021 · 1 comment · Fixed by #337
Closed

Generated npm script misses -b option #268

bodograumann opened this issue Jan 29, 2021 · 1 comment · Fixed by #337
Assignees
Labels
bug Classification: Something isn't working planned Tracking: Issue is tracked internally tiny Estimate: <= 2 hours

Comments

@bodograumann
Copy link

bodograumann commented Jan 29, 2021

I did my initial chromatic run with

npx chromatic --project-token=123456789 -b "storybook:build" -o "storybook-static"

given that I have vue-cli-plugin-storybook installed.
When asked to generate a 'chromatic' script in package.json I accepted. The script that was written is missing the -b option though, i.e. cannot run as-is.

"chromatic": "npx chromatic storybook:build -o storybook-static --project-token 123456789"

One more thing:
In this case I have chromatic installed as a dependency, so the npx can be left away in the script.

┆Issue is synchronized with this Asana task by Unito

@tmeasday tmeasday added bug Classification: Something isn't working tiny Estimate: <= 2 hours labels Feb 18, 2021
@tmeasday tmeasday added this to the Q2 Backlog milestone Feb 18, 2021
@tmeasday tmeasday modified the milestones: Q3 Backlog, Q2 Improvements Apr 1, 2021
@tmeasday tmeasday added the planned Tracking: Issue is tracked internally label Apr 1, 2021
@ghengeveld
Copy link
Member

Confirmed and fixed in #337

@tmeasday tmeasday removed this from the Q2 Improvements milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working planned Tracking: Issue is tracked internally tiny Estimate: <= 2 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants