Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chromatic script that can be added to package.json #337

Merged
merged 2 commits into from May 18, 2021
Merged

Fix chromatic script that can be added to package.json #337

merged 2 commits into from May 18, 2021

Conversation

ghengeveld
Copy link
Member

Fixes #268

@ghengeveld ghengeveld mentioned this pull request May 7, 2021
Closed
@ghengeveld ghengeveld requested a review from ndelangen May 7, 2021 14:01
tmeasday
tmeasday approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld merged commit ea1920c into next May 18, 2021
@ghengeveld ghengeveld deleted the fix-add-chromatic-script branch May 18, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated npm script misses -b option
3 participants
@ghengeveld @tmeasday @ndelangen