Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prebuilt Storybook package #317

Closed
ghengeveld opened this issue Apr 12, 2021 · 2 comments · Fixed by #319
Closed

Support prebuilt Storybook package #317

ghengeveld opened this issue Apr 12, 2021 · 2 comments · Fixed by #319
Assignees
@ghengeveld
Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request has workaround Tracking: This issue has an available workaround

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Apr 12, 2021 •
edited by sync-by-unito bot

Reported here.

Modern Web's Dev Server Storybook uses a prebuilt Storybook manager UI and doesn't require installing @storybook/web-components. Their guide also doesn't suggest installing it.

This is problematic because the Chromatic CLI will look for a supported view layer package and not find any. It can be resolved by installing @storybook/web-components manually, but we should just support this use case out of the box.

┆Issue is synchronized with this Asana task by Unito
@ghengeveld ghengeveld added customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request has workaround Tracking: This issue has an available workaround labels Apr 12, 2021
@tmeasday tmeasday added this to the Q2 Improvements milestone Apr 15, 2021
@tmeasday
Copy link
Member

@ghengeveld is this the fix? #319

@ghengeveld ghengeveld mentioned this issue Apr 22, 2021
Merged
@ghengeveld
Copy link
Member Author

@tmeasday It didn't at first, but I added explicit support for @web/dev-server-storybook now.

@domyen domyen mentioned this issue Apr 23, 2021
Closed
@tmeasday tmeasday removed this from the Q2 Improvements milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghengeveld ghengeveld

Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request has workaround Tracking: This issue has an available workaround
Projects
None yet
Milestone
No milestone
2 participants
@tmeasday @ghengeveld