Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/94 needs crossenv #105

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Fix/94 needs crossenv #105

merged 6 commits into from
Apr 6, 2020

Conversation

ndelangen
Copy link
Member

FIX #94

@ndelangen ndelangen self-assigned this Mar 25, 2020
@ndelangen ndelangen changed the base branch from master to next March 25, 2020 13:13
@ndelangen ndelangen added customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request labels Mar 25, 2020
@ndelangen ndelangen requested a review from tmeasday March 25, 2020 15:00
tmeasday
tmeasday reviewed Mar 26, 2020
View reviewed changes
bin/lib/package-json.js Outdated Show resolved Hide resolved
@tmeasday
Copy link
Member

Hmmm all this complication makes me think that maybe we should reconsider setting the env var after all. I was hoping we could just call cross-env from our dependencies somehow.

@ndelangen
Copy link
Member Author

Let's move it into the cli flag

@github-actions github-actions bot had a problem deploying to chromatic March 30, 2020 22:12 Failure
@ndelangen ndelangen requested a review from tmeasday April 6, 2020 08:52
tmeasday
tmeasday approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ndelangen ndelangen merged commit da20299 into next Apr 6, 2020
@ndelangen ndelangen deleted the fix/94-needs-crossenv branch April 6, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@ndelangen ndelangen

Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with adding script through cli
2 participants
@ndelangen @tmeasday