Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RENAME appCode to projectToken #109

Merged
merged 8 commits into from
Apr 6, 2020
Merged

RENAME appCode to projectToken #109

merged 8 commits into from
Apr 6, 2020

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Mar 31, 2020 •
edited

@ndelangen ndelangen requested a review from tmeasday March 31, 2020 08:49
@ndelangen ndelangen self-assigned this Mar 31, 2020
@github-actions github-actions bot requested a deployment to chromatic March 31, 2020 08:49 Pending
@github-actions github-actions bot requested a deployment to chromatic March 31, 2020 08:50 Pending
@github-actions github-actions bot requested a deployment to chromatic March 31, 2020 09:12 Pending
@github-actions github-actions bot requested a deployment to chromatic March 31, 2020 09:12 Pending
tmeasday
tmeasday reviewed Apr 1, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I guess we should change the name of the env var too?

@github-actions github-actions bot requested a deployment to chromatic April 3, 2020 10:02 Pending
@github-actions github-actions bot requested a deployment to chromatic April 3, 2020 10:02 Pending
@ndelangen ndelangen requested a review from tmeasday April 3, 2020 10:08
tmeasday
tmeasday reviewed Apr 3, 2020
View reviewed changes
.env.example Outdated Show resolved Hide resolved
bin/constants.js Outdated Show resolved Hide resolved
@ndelangen @tmeasday
Update .env.example
c4b1d43 
Co-Authored-By: Tom Coleman <tom@thesnail.org>
@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 08:01 Pending
@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 08:01 Pending
@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 08:19 Pending
@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 08:19 Pending
tmeasday
tmeasday approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 10:45 Pending
@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 10:46 Pending
@ndelangen ndelangen merged commit 990e6df into next Apr 6, 2020
@ndelangen ndelangen deleted the rename-appcode branch April 6, 2020 10:48
@oliverlloyd oliverlloyd mentioned this pull request Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@ndelangen ndelangen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @tmeasday