Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE the output when building storybook fails #112

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

ndelangen
Copy link
Member

This is the new situation when there's an error from storybook:
Screenshot 2020-04-06 at 19 27 56

This is when everything is fine:
Screenshot 2020-04-06 at 19 30 13

@ndelangen ndelangen self-assigned this Apr 6, 2020
@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 17:32 Pending
@ndelangen
Copy link
Member Author

ndelangen commented Apr 6, 2020

The red markings are custom from my terminal (I've configured it to always highlight the word "error" & "failed") (very useful btw)

@github-actions github-actions bot requested a deployment to chromatic April 6, 2020 17:33 Pending
@ndelangen ndelangen requested a review from tmeasday April 6, 2020 17:33
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @ndelangen

bin/tester/index.js Show resolved Hide resolved
@tmeasday tmeasday merged commit 96ce762 into next Apr 8, 2020
@tmeasday tmeasday deleted the fix/build-storybook-error-message branch April 8, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants