New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support only testing components affected by recent git changes #304
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
eefd42a
Add --only-changed feature
ghengeveld 0ed090a
Skip onlyStoryFiles
ghengeveld 98b1562
Reword
ghengeveld 779b1f2
Preserve missing specs when running with --only-changed
ghengeveld 3c82255
Merge branch 'next' into determine-affected-stories
ghengeveld 228fb24
Add some helper/debug scripts
ghengeveld 68b4fee
Merge branch 'next' into determine-affected-stories
ghengeveld 81ce9e4
Trim the final output some more
ghengeveld 9acd377
Log the target filename
ghengeveld 49d09c2
Omit webpack stuff
ghengeveld dc33762
ESM
ghengeveld bef92a9
Rename file and add script
ghengeveld ebfd5b3
Rename file and add script
ghengeveld 51514a5
Pass changedFiles as args
ghengeveld feb1c0d
Cleanup
ghengeveld aa1010b
Use real configDir and staticDir + big refactor
ghengeveld 7e81012
Move dependency tracing to upload step so we can skip upload if nothi…
ghengeveld 516dd7d
Merge branch 'next' into determine-affected-stories
ghengeveld 51ee57b
Deal with zero changed files since baseline commit(s), in conjunction…
ghengeveld 3cbf88b
Update bin/lib/parseArgs.js
ghengeveld 4e71b5a
Update bin/lib/parseArgs.js
ghengeveld 4c66cc7
Fix tests
ghengeveld 2639b3d
Rename getBaselineCommits to getParentCommits
ghengeveld 176b5e8
Rename baselineCommits to parentCommits
ghengeveld b3d3539
Rewording
ghengeveld 35d57b0
5.7.2-canary.0
ghengeveld 56592de
Pass --webpack-stats-json to build-storybook
ghengeveld 7e5007c
5.7.2-canary.1
ghengeveld 06e9884
Check Storybook version before using --webpack-stats-json flag
ghengeveld eba9c79
Fix messaging
ghengeveld 290af6d
5.7.2-canary.2
ghengeveld 7dba03b
Fix messaging
ghengeveld c7853fd
5.7.2-canary.3
ghengeveld 24bc6b5
Catch invalid commit and warn about it
ghengeveld 3da983d
Change wording for snapshot progress message
ghengeveld 6852874
Warn when using --only-changed without stats file
ghengeveld b1d5cdf
Update tests
ghengeveld c939a19
Don't infer preserveMissingSpecs on --only or --only-changed
ghengeveld 6a5a56f
Run skip mutation when there's no changedFiles
ghengeveld db8ead2
Better messaging when bailing on --only-changed
ghengeveld bda4f29
5.7.2-canary.4
ghengeveld 7c2fc81
Use actual baseline commits from which to determine changed files
ghengeveld 782592c
Fix skipped count
ghengeveld 149ced6
Fix baseline commits retrieval
ghengeveld e4de04f
Narrow down the try/catch so we don't catch too much
ghengeveld d5219c0
Support prerelease versions
ghengeveld 61d752f
onlyStoryFiles is an object
ghengeveld c61894c
Not always due to --skip
ghengeveld 3339bda
We don't need manager-stats
ghengeveld 18b0a51
Better logs
ghengeveld 1e17d11
Log fixes
ghengeveld 344b9ab
Reword final status messages
ghengeveld 0d4d613
Fix upload success message
ghengeveld a1a0c44
Fix upload success message
ghengeveld 5bf0e1a
Update stats reporting
ghengeveld 9b3f004
5.7.2-canary.5
ghengeveld 2b67c45
Merge branch 'next' into determine-affected-stories
ghengeveld b305bb8
Merge branch 'next' into determine-affected-stories
ghengeveld 2274698
Upload may have been skipped
ghengeveld 04e5ca3
5.7.2-canary.6
ghengeveld cac4ac5
Fix numbering
ghengeveld f50b263
5.7.2-canary.7
ghengeveld 15ccedd
Support only and onlyChanged in GitHub Action
ghengeveld bf090c7
Run with --only-changed against staging
ghengeveld a2c565a
Fix changedFiles is undefined error
ghengeveld f7e3700
Bump storybook
ghengeveld de5bc45
Remove --webpack-stats-json flag
ghengeveld 679278b
Better messaging
ghengeveld 6b7ac73
Set proper exitCode and show suitable message when inheriting a build
ghengeveld 5517fd2
5.7.2-canary.8
ghengeveld 4a6a860
Merge branch 'next' into determine-affected-stories
ghengeveld 1781dc4
Fix story data
ghengeveld 95f0f76
Update CI scripts
ghengeveld eb7a13d
Exit once uploaded
ghengeveld 8260dc9
Merge branch 'next' into determine-affected-stories
ghengeveld 19fd509
Don't skip build when changedFiles or onlyStoryFiles is empty
ghengeveld 470ba7d
5.7.2-canary.9
ghengeveld 61b72f1
Look at package.json rather than node_modules to determine installed …
ghengeveld 5c33cbc
5.7.2-canary.10
ghengeveld c12588d
Add addon-essentials
ghengeveld 88f99d3
5.7.2-canary.11
ghengeveld 862d33c
Fix tests
ghengeveld 6ed15f2
Merge branch 'next' into determine-affected-stories
ghengeveld File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs
legacy:false
!!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is such a gotcha 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IKR. I'm not sure what we can do about it, beyond renaming the field entirely.