Fix npx chromatic timing out on build-storybook
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
changed the title
|
Available as a pre-release: |
ghengeveld
commented
Apr 28, 2021
ghengeveld
changed the title
npx chromatic timing out on build-storybook
tmeasday
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
yarn-or-npmto decide which client to use. It appears the original method doesn't work because I couldn't get it to use Yarn while runningyarn chromatic. So rather than trying to detect the currently used client, this looks at the presence of yarn.lock (among other things) to determine the correct client.Important detail: this means we'll be executing
npm run build-storybookinstead ofnode /path/to/npm-cli.js run build-storybook. It remains to be seen whether that will have an impact.