Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix determining viewLayer when using transitive dependency #344

Merged
merged 4 commits into from May 18, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 18, 2021

Fixes #342

This also drops addons reporting because we aren't using it and it's not reliable anyway.

@ghengeveld ghengeveld requested a review from tmeasday May 18, 2021 05:31
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM apart from dropping addons -- we do use the fact that you are using docs or essentials to decide whether to show the docs tab on the component screen.

We'll need to change that in Chromatic before we can drop it.

bin/lib/getStorybookInfo.js Show resolved Hide resolved
@ghengeveld
Copy link
Member Author

This LGTM apart from dropping addons -- we do use the fact that you are using docs or essentials to decide whether to show the docs tab on the component screen.

We'll need to change that in Chromatic before we can drop it.

Right, I wasn't aware of that. Reverted.

@ghengeveld ghengeveld merged commit 0e1b83b into next May 18, 2021
@ghengeveld ghengeveld deleted the fix-determine-viewlayer branch May 18, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find a supported Storybook viewlayer as transitive dependency
2 participants