Implement async build creation process #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CH-1759 Update CLI to use new build creation API
Introduce new "initialize build" step. Deal with partial build data. Drop "retryable" build mechanism. |
ghengeveld
force-pushed
the
ghengeveld/ch-1759-update-cli-to-use-new-build-creation-api
branch
from
2886b53
to
ac199d3
Compare
|
Published as |
|
I'm calling this done but holding off the merge until we ship the backend changes. |
|
@ghengeveld I tested this on a git repo with no origin setup and it errored with: |
Opened a PR to address this here: https://github.com/chromaui/chromatic/pull/6162 |
ghengeveld
deleted the
ghengeveld/ch-1759-update-cli-to-use-new-build-creation-api
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CLI to use the new three-step build creation process:
announceBuild➡️publishBuild➡️verifyBuildAlso this adds
mergeCommitto the build info.Relies on https://github.com/chromaui/chromatic/pull/6005
and https://github.com/chromaui/chromatic/pull/6162