Improve the failure message when there's only one git commit #689
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thafryer
requested review from
mark-vn,
JonathanKolnik,
yannbf and
ghengeveld
and removed request for
JonathanKolnik
mark-vn
reviewed
Dec 7, 2022
yannbf
approved these changes
Dec 7, 2022
Slight clarity tweak
mark-vn
approved these changes
Dec 8, 2022
| @@ -14,7 +14,7 @@ export default (isGithubAction = false) => | |||
| With {bold actions/checkout@v2}, you can enable this by setting 'fetch-depth: 0'. | |||
| ${info} Read more at ${link('https://www.chromatic.com/docs/github-actions')} | |||
| - You've only made a single commit so far. | |||
| Chromatic needs an additional commit to be able to detect what's changed. | |||
| Please make at least one additional commit to be able to detect what's changed. | |||
There was a problem hiding this comment.
Alright, I'm nitpicking here, but maybe Please make at least one additional commit for Chromatic to be able to detect what's changed? What do you think @thafryer?
There was a problem hiding this comment.
Looks good!! @alright-fine
|
@thafryer Made my changes. Please lmk if that works so I'm not just approving my own language 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of customers write in to support when their builds fail due to one commit. This ticket is to improve the messaging.