Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we exit with a code at the end #770

Merged
merged 1 commit into from Jun 14, 2023
Merged

Conversation

tmeasday
Copy link
Member

I missed this bit from the old code:

log.info('');
process.exit(ctx.exitCode);

Not sure if the log is still necessary but this solves the immediate problem

@skitterm skitterm self-requested a review June 14, 2023 17:46
Copy link
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, restores the process.exit() that we've had for awhile. Seems we can wait on making improvements to that part.

@ghengeveld ghengeveld merged commit 12a029a into main Jun 14, 2023
18 of 21 checks passed
@ghengeveld ghengeveld deleted the tom/fix-zero-exit-code branch June 14, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants