Fix Unexpected build status: PREPARED error
#801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
changed the title
completedAt to know when build has completed, rather than status !== IN_PROGRESS
ghengeveld
changed the title
Unexpected build status: PREPARED error
yannbf
reviewed
Aug 23, 2023
Broken, failed and cancelled builds are already handled as valid completed builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the CLI could crash if the
waitForBuildpolling happened to return a build while it wasPUBLISHEDorPREPARED. These would be considered "complete" (not in progress) but the code that runs after the build is complete (rightfully) does not handle those build statuses.I could've updated the status check to take
PUBLISHEDandPREPAREDinto account but it seems more resilient to look atcompletedAtinstead.