Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog for 9.0.0 and update auto config to prevent issue in the future #854

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 10, 2023

Auto messed up the last release, probably due to the prerelease setting. Let's get rid of it and disable onlyGraduateWithReleaseLabel as well, because it's not working as advertised. We can make do without any next releases.

📦 Published PR as canary version: 9.0.1--canary.854.6826342859.0

✨ Test out this PR locally via:

npm install chromatic@9.0.1--canary.854.6826342859.0
# or 
yarn add chromatic@9.0.1--canary.854.6826342859.0

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is the project token stuff a breaking change?

@ghengeveld
Copy link
Member Author

ghengeveld commented Nov 10, 2023

Is the project token stuff a breaking change?

No it's not. They're optional flags. It should've been released as v8.1.0 (since the PR was tagged minor).

@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Nov 10, 2023
@ghengeveld ghengeveld added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 9bcfd0e Nov 10, 2023
22 of 23 checks passed
@ghengeveld ghengeveld deleted the fix-auto-release branch November 10, 2023 15:09
@ghengeveld
Copy link
Member Author

🚀 PR was released in v9.1.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Nov 17, 2023
@benjaminkomen
Copy link

I was already wondering why 9.0.0 was a major release, I didn't see any breaking changes

@ghengeveld
Copy link
Member Author

Yeah, that was the result of a misconfiguration. It should have been a minor release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants