Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should throw error when using TurboSnap but missing a stats file. #899

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Jan 25, 2024

📦 Published PR as canary version: 10.7.0--canary.899.7663620268.0

✨ Test out this PR locally via:

npm install chromatic@10.7.0--canary.899.7663620268.0
# or 
yarn add chromatic@10.7.0--canary.899.7663620268.0

@thafryer thafryer added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Jan 25, 2024
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thafryer Please move the message files from the warnings to the errors directory.

@thafryer thafryer marked this pull request as ready for review January 25, 2024 15:36

Verified

This commit was signed with the committer’s verified signature.
javsalgar Javier J. Salmerón García

Verified

This commit was signed with the committer’s verified signature.
javsalgar Javier J. Salmerón García
@thafryer thafryer force-pushed the jarel/ap-3947-warn-user-about-missing-preview-statsjson-when-running-with branch from df17b16 to 08bab4a Compare January 26, 2024 03:00
@thafryer thafryer added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 14c1673 Jan 26, 2024
@thafryer thafryer deleted the jarel/ap-3947-warn-user-about-missing-preview-statsjson-when-running-with branch January 26, 2024 03:27
@ghengeveld
Copy link
Member

🚀 PR was released in v10.6.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants