Avoid build verify timeout when waiting for upgrade builds #922
+144
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torybooks-time-out-at-the
ghengeveld
changed the title
ghengeveld
added
release
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ghengeveld
deleted the
ghengeveld/ap-4252-upgrade-builds-of-large-storybooks-time-out-at-the
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defers the timeout for extract (verify step) until all upgrade builds are completed, so that upgrade builds will not cause the build to time out after 3 minutes (the timeout for extract). A new timeout of 60 minutes is introduced to prevent upgrade builds from potentially stalling builds indefinitely.
📦 Published PR as canary version:
10.9.7--canary.922.7932883071.0✨ Test out this PR locally via:
npm install chromatic@10.9.7--canary.922.7932883071.0 # or yarn add chromatic@10.9.7--canary.922.7932883071.0