Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display full error message when storybookBaseDir is invalid #932

Merged
merged 3 commits into from Mar 6, 2024
Merged

Display full error message when storybookBaseDir is invalid #932

merged 3 commits into from Mar 6, 2024
+2 −2

Conversation

andrewortwein
Copy link
Contributor

@andrewortwein andrewortwein commented Mar 1, 2024 •
edited by ghengeveld

The CLI is supposed to spit out an error message like this:

✖ TurboSnap disabled until base directory is set correctly
The base directory allows TurboSnap to trace files.
Set the --storybook-base-dir option as the relative path from the repository root to the Storybook project root.
Run @chromatic-com/turbosnap-helper to get your base directory value.

But only the last line is showing unless the debug flag is enabled. This change fixes that.

QA by running this on a project using --only-changed and an invalid --storybook-base-dir.

📦 Published PR as canary version: 11.0.4--canary.932.8166549286.0

✨ Test out this PR locally via:

npm install chromatic@11.0.4--canary.932.8166549286.0
# or 
yarn add chromatic@11.0.4--canary.932.8166549286.0

@andrewortwein andrewortwein marked this pull request as ready for review March 1, 2024 02:22
@andrewortwein andrewortwein added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 6, 2024
@andrewortwein andrewortwein added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@andrewortwein andrewortwein added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 975eceb Mar 6, 2024
20 checks passed
@andrewortwein andrewortwein deleted the andrew/ap-4312-when-a-build-fails-because-of-an-invalid-storybookbasedir-i branch March 6, 2024 03:30
@ghengeveld
Copy link
Member

🚀 PR was released in v11.0.3 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thafryer thafryer thafryer approved these changes

Assignees

@ghengeveld ghengeveld

Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewortwein @ghengeveld @thafryer