Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for boolean value to junitReport option #937

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Mar 5, 2024

This PR adds the functionality to generate the JUnit report with the default naming scheme if the flag is set to true.

To QA

  1. Run npx chromatic@11.0.1--canary.937.8150625203.0 -t=PROJECT_TOKEN --junit-report=true
  2. Run the Unit tests.
📦 Published PR as canary version: 11.0.3--canary.937.8162574426.0

✨ Test out this PR locally via:

npm install chromatic@11.0.3--canary.937.8162574426.0
# or 
yarn add chromatic@11.0.3--canary.937.8162574426.0

@thafryer thafryer added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 5, 2024
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK 👍

@ghengeveld ghengeveld changed the title Generate JUnit report with Default Naming scheme Support boolean flag for junitReport option Mar 5, 2024
@ghengeveld ghengeveld changed the title Support boolean flag for junitReport option Fix support for boolean value to junitReport option Mar 5, 2024
@thafryer thafryer added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@JonathanKolnik JonathanKolnik added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@thafryer thafryer added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 30bc7c4 Mar 5, 2024
20 checks passed
@thafryer thafryer deleted the jarel/ap-4316-cli-exits-unexpectedly-when-junitreport-true-is-in-my-config branch March 5, 2024 20:24
@ghengeveld
Copy link
Member

🚀 PR was released in v11.0.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying junitReport: true makes chromatic crash when reporting build status
3 participants