Do not prompt to install chromatic script during E2E builds #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitterm
approved these changes
Mar 6, 2024
Comment on lines
+63
to
+65
| export function isE2EBuild(options: Options) { | ||
| return options.playwright || options.cypress; | ||
| } |
There was a problem hiding this comment.
Nice. We could use this for the "flag the project as e2e" thing in the future (if we ever feel the need to handle projects switching from storybook-e2e or vice versa).
Comment on lines
+716
to
+723
| it('does not propmpt you to add a script to your package.json for E2E builds', async () => { | ||
| const ctx = getContext(['--project-token=asdf1234', '--playwright']); | ||
| await runAll(ctx); | ||
| const spy = vi.spyOn(checkPackageJson, 'default'); | ||
| expect(spy).not.toHaveBeenCalled(); | ||
| expect(confirm).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
tevanoff
added
release
tevanoff
deleted the
todd/ap-4260-cli-prompts-user-to-install-wrong-chromatic-command
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI will prompt to install a chromatic script if one does not already exist in
package.json. This will be the wrong command for E2E builds and may be missing necessary env vars. This disables that for E2E builds for the time being.📦 Published PR as canary version:
11.0.5--canary.941.8178177052.0✨ Test out this PR locally via:
npm install chromatic@11.0.5--canary.941.8178177052.0 # or yarn add chromatic@11.0.5--canary.941.8178177052.0