Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e peer dep versions #943

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix e2e peer dep versions #943

merged 1 commit into from
Mar 11, 2024

Conversation

tevanoff
Copy link
Contributor

@tevanoff tevanoff commented Mar 8, 2024

The ^0.5.2 version specifier will only match 0.5.x versions, but we're at 0.6.x.

📦 Published PR as canary version: 11.0.9--canary.943.8236313284.0

✨ Test out this PR locally via:

npm install chromatic@11.0.9--canary.943.8236313284.0
# or 
yarn add chromatic@11.0.9--canary.943.8236313284.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@thafryer
Copy link
Member

thafryer commented Mar 8, 2024

How common do we think this is going to be? A part of me thinks we can benefit from having CLI and E2E live in one singular monorepo.

@tevanoff tevanoff added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 11, 2024
@tevanoff
Copy link
Contributor Author

How common do we think this is going to be? A part of me thinks we can benefit from having CLI and E2E live in one singular monorepo.

@thafryer it shouldn't be common, it's just that semver matching is weird with 0.x versions and so what we had specified only matched 0.5.x. It should now match all 0.x.x versions.

@tevanoff tevanoff added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit d7a839e Mar 11, 2024
21 of 23 checks passed
@tevanoff tevanoff deleted the todd/fix-e2e-peer-dep-versions branch March 11, 2024 16:24
@ghengeveld
Copy link
Member

🚀 PR was released in v11.0.8 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants