Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double quotes around command arguments #985

Merged
merged 1 commit into from
May 15, 2024

Conversation

tevanoff
Copy link
Contributor

@tevanoff tevanoff commented May 14, 2024

When passing file paths to the git ls-files command to search for package manifest files, the paths are currently wrapped in single quotes.

This seems to be problematic on windows:

const results = await execGitCommand(`git ls-files --full-name -z 'C:/my/project/package.json'`);
console.log('execGitCommand results:', results);
...
execGitCommand results:
Done in 0.58s.

Switching to double quotes does the trick:

const results = await execGitCommand(`git ls-files --full-name -z "C:/my/project/package.json"`);
console.log('execGitCommand results:', results);
...
execGitCommand results: package.json
Done in 0.64s.
📦 Published PR as canary version: 11.3.6--canary.985.9099248277.0

✨ Test out this PR locally via:

npm install chromatic@11.3.6--canary.985.9099248277.0
# or 
yarn add chromatic@11.3.6--canary.985.9099248277.0

@tevanoff tevanoff requested a review from ghengeveld May 14, 2024 23:09
@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels May 15, 2024
@tevanoff tevanoff added release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels May 15, 2024
Base automatically changed from todd/fix-dependency-tracing to main May 15, 2024 15:57
The single quotes are not working on windows
@tevanoff tevanoff force-pushed the todd/fix-dependency-tracing-windows branch from afc2e28 to e7be52e Compare May 15, 2024 16:09
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d4b3fe21 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d4b3fe2) Report Missing Report Missing Report Missing
Head commit (e7be52e) 8467 6669 78.76%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#985) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@tevanoff tevanoff added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 652f985 May 15, 2024
23 checks passed
@tevanoff tevanoff deleted the todd/fix-dependency-tracing-windows branch May 15, 2024 16:19
@ghengeveld
Copy link
Member

🚀 PR was released in v11.3.5 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants