Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch package manager to pnpm and upgrade to Storybook 8 #987

Closed
wants to merge 34 commits into from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 17, 2024

What I did:

@ghengeveld requested this to be upgraded to storybook 8.x in order to use the visual regression addon.,

  • I ran the storybook upgrade command
  • I ran some manual migrations
  • I applied some manual fixes
  • Migrated the repo to use pnpm
  • tweaked the CI so it uses pnpm
📦 Published PR as canary version: 11.4.1--canary.987.9175126545.0

✨ Test out this PR locally via:

npm install chromatic@11.4.1--canary.987.9175126545.0
# or 
yarn add chromatic@11.4.1--canary.987.9175126545.0

@ndelangen ndelangen requested a review from ghengeveld May 17, 2024 10:38
@ndelangen ndelangen added dependencies Classification: Update one or more dependencies version minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged labels May 17, 2024
@ethriel3695 ethriel3695 requested a review from tmeasday May 20, 2024 23:38
Copy link

codacy-production bot commented May 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 764456e1 46.15% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (764456e) Report Missing Report Missing Report Missing
Head commit (97d57bc) 8451 6663 78.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#987) 13 6 46.15%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@thafryer
Copy link
Member

@ndelangen What led to us using PNPM here? If you were just experimenting, I will ignore. :) Updating to Yarn 4 is very welcome though if you just wanted to update to a newer package manager.

@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels May 21, 2024
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be doing more than upgrade Storybook and the package manager. Ideally this change should not affect the CLI functionally.

node-src/tasks/verify.ts Outdated Show resolved Hide resolved
node-src/tasks/verify.ts Outdated Show resolved Hide resolved
node-src/tasks/verify.ts Outdated Show resolved Hide resolved
node-src/ui/tasks/verify.ts Outdated Show resolved Hide resolved
@ghengeveld ghengeveld changed the title switch to pnpm & upgrade storybook Switch package manager to pnpm and upgrade to Storybook 8 May 21, 2024
ethriel3695 and others added 3 commits May 21, 2024 06:53
Throwing an error if the account doesn't exist

Co-authored-by: Gert Hengeveld <info@ghengeveld.nl>
Co-authored-by: Gert Hengeveld <info@ghengeveld.nl>
@ethriel3695
Copy link
Contributor

This PR seems to be doing more than upgrade Storybook and the package manager. Ideally this change should not affect the CLI functionally.

@ghengeveld some changes were necessary to get tests to pass after changing to pnpm.

Other changes were due to Typescript yelling at me. I've reverted those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Classification: Update one or more dependencies version minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants