-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch package manager to pnpm and upgrade to Storybook 8 #987
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
@ndelangen What led to us using PNPM here? If you were just experimenting, I will ignore. :) Updating to Yarn 4 is very welcome though if you just wanted to update to a newer package manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to be doing more than upgrade Storybook and the package manager. Ideally this change should not affect the CLI functionally.
Throwing an error if the account doesn't exist Co-authored-by: Gert Hengeveld <info@ghengeveld.nl>
Co-authored-by: Gert Hengeveld <info@ghengeveld.nl>
@ghengeveld some changes were necessary to get tests to pass after changing to pnpm. Other changes were due to Typescript yelling at me. I've reverted those. |
What I did:
@ghengeveld requested this to be upgraded to storybook 8.x in order to use the visual regression addon.,
pnpm
pnpm
📦 Published PR as canary version:
11.4.1--canary.987.9175126545.0
✨ Test out this PR locally via:
npm install chromatic@11.4.1--canary.987.9175126545.0 # or yarn add chromatic@11.4.1--canary.987.9175126545.0