Avoid invalid CSS generation for styles using vendor pseudo-elements #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think it's a good improvement to generalize things. Opera isn't among Storybook's nor Chromatic's supported browsers, so I consider that out of scope. |
ghengeveld
added
minor
ghengeveld
approved these changes
May 8, 2024
ghengeveld
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only handling the
::-webkit-scrollbar-thumband::-webkit-slider-thumbvendor pseudo-elements. This change generalizes the code to handle any vendor-specific pseudo-elements (i.e.::-webkit-*,::-moz-*, and::-ms-*) the same way. Apparently there are also some old, pre-Webkit Opera CSS elements (starting with-o-), but I'm not sure if there are any such pseudo-elements. In any case, it is unlikely anyone is using them, if there are.Made sure the unit tests cover all these patterns.