test both pipe and WebSocket connections

chromedp · Jun 26, 2021 · 609bd13 · 609bd13
1 parent a71350f
commit 609bd13
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -17,4 +17,5 @@ jobs:
     - name: Test
       run: |
         TMPDIR=$RUNNER_TEMP go test -v ./...
+        TMPDIR=$RUNNER_TEMP CHROMEDP_WS=1 go test -v ./...
         ./contrib/docker-test.sh
diff --git a/chromedp_test.go b/chromedp_test.go
@@ -72,6 +72,11 @@ func init() {
 	if noSandbox := os.Getenv("CHROMEDP_NO_SANDBOX"); noSandbox != "false" {
 		allocOpts = append(allocOpts, NoSandbox)
 	}
+
+	// To test WebSocket connection.
+	if useWS := os.Getenv("CHROMEDP_WS"); useWS != "" && useWS != "false" {
+		allocOpts = append(allocOpts, DebuggingPort(0))
+	}
 }
 
 var browserOpts []ContextOption

diff --git a/contrib/docker-test.sh b/contrib/docker-test.sh
@@ -21,4 +21,16 @@ set -e
     chromedp/headless-shell:latest -test.v
 )
 
+(set -x;
+  docker run \
+    --rm \
+    --volume=$PWD:/chromedp \
+    --entrypoint=/chromedp/chromedp.test \
+    --workdir=/chromedp \
+    --env=PATH=/headless-shell \
+    --env=HEADLESS_SHELL=1 \
+    --env=CHROMEDP_WS=1 \
+    chromedp/headless-shell:latest -test.v
+)
+
 popd &> /dev/null