Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filtering visible nodes as an option #636

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enable filtering visible nodes as an option #636

wants to merge 1 commit into from

Commits on May 29, 2020

  1. Enable filtering visible nodes as an option

    Currently, we cannot tell ChromeDP to select all visible nodes without
    waiting for them.
    
    If one calls
    ```
    NodeIDs(selector, WaitVisible, AtLeast(0))
    ```
    
    chromeDP selects all nodes with the selector and then wait for them to be visible.
    This might hang if it never happens and the node keeps being hidden.
    
    With this PR, we can do
    ```
    NodeIDs(selector, FilterVisible, AtLeast(0))
    ```
    
    However, the following will still hang, since the waiting is done before the filtering;
    as we need the nodes to be at least ready to filter them. I think it's OK,
    but it might be confusing.
    
    ```
    NodeIDs(selector, WaitVisible, FilterVisible, AtLeast(0))
    ```
    Karel Bilek committed May 29, 2020
    Configuration menu
    Copy the full SHA
    b4a280f View commit details
    Browse the repository at this point in the history