Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Firefox 44 in pinning-test #314

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Firefox 44 in pinning-test #314

wants to merge 3 commits into from

Conversation

prefixtitle
Copy link
Contributor

@prefixtitle prefixtitle commented Sep 11, 2017 •
edited

image

pinning-test.badssl.com was added to Firefox 44 by bug ID: 1218515.

Added wikipedia to HPKP and line break.

Solves issue #298 and #307.

@lgarron
Copy link
Collaborator

lgarron commented Sep 12, 2017

Thanks!

Could you do at least two things?

  • Fit the text on two lines (no explicit line break).
  • Avoid phrasing the "official Chrome builds" explanation in a way that implies that it's not present in any Firefox builds.

@prefixtitle
Copy link
Contributor Author

image

Done.

@lgarron lgarron force-pushed the master branch 3 times, most recently from 1d2c736 to 8b893ec Compare October 20, 2017 19:06
@lgarron lgarron force-pushed the master branch 2 times, most recently from 1dfcd2b to 9ca20c0 Compare April 21, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prefixtitle @lgarron