-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
…ons. Reland notes: Fixed presubmit test failures in - tools/resources/svgo_presubmit_test.py - ui/webui/resources/tools/bundle_js_test.py Specifically updating: - svgo: 2.8.0 -> 3.0.2 - terser: 5.16.2 -> 5.20.0 - rollup: 3.12.0 -> 3.29.4 - eslint: 8.33.0 -> 8.50.0 rollup notes: With the latest version of Rollup, bundled files are unfortunately a bit larger, due to fixing a previous bug [1], which incorrectly only kept the first line of all license header comments. The new behavior is correct (see updated tests), so perhaps we should look into ways of deduplicating license header comments in the future, to further reduce the file size. svgo notes: - Latest version includes a fix for [2] which was affecting some SVG files, and has resulted in using 'minifyStyles: false' in tools/resources/svgo.config.js as a workaround, see [3]. - Updated svgo.config.js to account for the breaking change at [4]. - Updated svgo_presubmit_test.py since it now re-arranges the order of SVG attributes as part of the optimization. [1] rollup/rollup#4953 [2] svg/svgo#1672 [3] https://source.chromium.org/chromium/chromium/src/+/main:tools/resources/svgo.config.js;l=17-18;drc=4046a6ad0dfa25c3ec4ff3a0f2019badcd4ede70 [4] svg/svgo@6295c60 Bug: None Change-Id: I12ca6f1204868a8592d03b24852c12c97e4e5b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908394 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#1204712}
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
937cea04689b7b8dcf3cb9adbb12c79d1d6c38bb | ||
ddc7cddc319ae5689ebf2c927e284814f2892e47 |
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.