Removed a Bad word / misspelling from the enum description in Blink/node.h #171

YogeshTembe · 2023-05-19T06:03:22Z

In the description of enum "NodeFlags" there is a bad word used, its definitely a misspelling. So corrected a minor mistake in this description.
Please let me know if any other change is required.

In the description of enum "NodeFlags" there is a bad word used, its definitely a misspelling. So corrected a minor mistake in this description.

google-cla · 2023-05-19T06:03:26Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Change-Id: I9c267d1f2e1089f164fc56f492acdc5aa0990710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4044290 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5414@{chromium#171} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}

Jsm34 · 2023-05-28T15:10:32Z

Capi Sviluppando Cronologie @

(cherry picked from commit bd38ef8) Bug: 1457150 Change-Id: I97eb16d59d90903b0108975dfe701d20ea6153d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637184 Commit-Queue: Florian Jacky <fjacky@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1162518} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4650672 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Florian Jacky <fjacky@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#171} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}

Add Chrome feature flag as a kill switcher. (cherry picked from commit cda2c90) Bug: 1448734 Change-Id: I78bcdf8d4cff389c29e753d3c783245b90ac05bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4564639 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1149216} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574612 Cr-Commit-Position: refs/branch-heads/5790@{chromium#171} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

This also adds some vlogging for getProxyConfig calls. (cherry picked from commit 3589eb9) Bug: 1480549 Change-Id: I15217d93850b35be8feae4899136296f8adb3e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4854159 Commit-Queue: Dustin Mitchell <djmitche@chromium.org> Reviewed-by: Brianna Goldstein <brgoldstein@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1194325} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850938 Reviewed-by: Andrew Williams <awillia@chromium.org> Auto-Submit: Dustin Mitchell <djmitche@chromium.org> Commit-Queue: Andrew Williams <awillia@chromium.org> Cr-Commit-Position: refs/branch-heads/5993@{chromium#171} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}

…P feature In the original CL [1] to consider BREFs/RFS in the construction of the StorageKey, new functionality relied on the incorrect runtime- enabled feature. This CL corrects these functions to use the actual deprecation trial flag: kDisableThirdPartyStoragePartitioning. [1] https://chromium-review.googlesource.com/c/chromium/src/+/4299752 (cherry picked from commit 3975883) Bug: 1420663 Change-Id: I4559b37fd5d7b350f735a123c113bc2eea7f7000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296258 Commit-Queue: Kyra Seevers <kyraseevers@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1111892} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304139 Cr-Commit-Position: refs/branch-heads/5615@{chromium#171} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

Roll Chrome Win64 PGO profile from chrome-win64-6045-1696715571-d84da412e9c5fc9ade65c60e950024ac5549ef25.profdata to chrome-win64-6045-1696736910-cb85a12ea06fff439a36555b9fb654019e458d74.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7961a79313a60ad5ab6eeb3d648e9c99a54a70f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921055 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#171} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

…-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6b94d79aa46448be5c311c0f5449986d8e5cc68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006198 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#171} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

Roll Chrome Win32 PGO profile from chrome-win32-6167-1702115692-0481d2d915d8e43619756d3d1b154477324dae84.profdata to chrome-win32-6167-1702141771-4a47d306810f70667279ceba7e7bcfcad14ec83c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c1eebe13300394feaa3265c3aea18ad0e59d9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107902 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#171} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

This CL fixes the issue where the keyboard lock state wasn't being recorded correctly on non-Mac platforms because we were collecting the metrics when entering fullscreen, and keyboard lock was engaging right after that. (cherry picked from commit ff1287a) Bug: 1509351 Change-Id: I3d40cf1633d466bf7e8d2bfa046517825da5b40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5186117 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Mike Wasserman <msw@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1251852} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237646 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#171} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

…upport Right now storage-deprecation-trial-disabled-session.sub.https.html is flakey because if a some other test already registered for the DT then all other tests run in that tab stay registered. We should fix this by allowing unregistration for a given tab when the OT is missing. This not only fixes the flake but also aligns us closer to what user expectations would be (if they're testing adding and removing the DT token from the header). This CL also adds support for insecure URLs as it's a deprecation trial. (cherry picked from commit 9a96a58) Bug: 1399319, 1412626 Change-Id: Idc6e91bf74742ef39e8d296727e9b3e1be86875c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219270 Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1101183} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219780 Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#171} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

…efore shutdown It seems gesture streams started immediately before shutdown still reach the widget even though we block events on the widget and its views tree. This CL adds a check to prevent a destroyed object from trying to process these events. The view is still alive during the shutdown animation so other gesture streams are still processed but those do not crash. (cherry picked from commit 0723736) Test: manual Bug: b/302708219 Change-Id: I1aeac990e8aac96a683373863be81bc3ce66f566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310039 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Yongshun Liu <yongshun@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1264061} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323730 Cr-Commit-Position: refs/branch-heads/6312@{#171} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

This CL disables DevToolsTest.TestRawHeadersWithRedirectAndHSTS on Mac platforms. (cherry picked from commit 277b725) Bug: 1471349 Change-Id: Ifcaea31edf651e347e9e57834dd9bad2636562ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4775527 Reviewed-by: Jack Hsieh <chengweih@chromium.org> Commit-Queue: Jack Hsieh <chengweih@chromium.org> Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org> Auto-Submit: Dibyajyoti Pal <dibyapal@chromium.org> Owners-Override: Dibyajyoti Pal <dibyapal@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1182843} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779162 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Owners-Override: Donn Denman <donnd@chromium.org> Reviewed-by: Sirisha Kavuluru <skavuluru@google.com> Commit-Queue: Sirisha Kavuluru <skavuluru@google.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#171} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Roll Chrome Win64 PGO profile from chrome-win64-6367-1711229771-3cd786c64e55ed2d3f2b2c4fb6d70e65f097506e-5732af2c7bbd5ea15d8f312b7e3790d326eab3c6.profdata to chrome-win64-6367-1711250628-8546bc800b78b27a1196d8125825536bf1f4f69a-1a14b7ce485b2803db7225fc525f89e90de9c261.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieba5a67dc61ff872d32340ffca657b87e1b54e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390449 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#171} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Change-Id: I43b783291de26f328156b942c6c4799e9fa70ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467556 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#171} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

IsVisible is called in views::DesktopWindowTreeHostPlatform::OnClosed. When WaylandBubble is destroyed it activates the parent window within the same callstack. The ExtensionPopup widget is observing its parent activation change and checks IsVisible. To prevent dereferencing null platform_window, perform a check here. A better solution could be to post-task for activation changes handled within ozone/wayland if the platform is not involved. But I'm uncertain whether such bubble widget have an expectation of async activation changes. (cherry picked from commit bca8212) Bug: 337572775 Change-Id: I412eb456241ea3ddc4bde75ffcdd407b9f5a44b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5535519 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1300370} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545947 Cr-Commit-Position: refs/branch-heads/6478@{#171} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}

Add metric for recording sizes of SameSite=None cookies (cherry picked from commit 64de4b6) Bug: 1356292 Change-Id: I4db02d84fdd1f8f09374f350963be63d3cc6998b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854419 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1039983} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3861491 Commit-Queue: Krishna Govind <govind@chromium.org> Auto-Submit: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/branch-heads/5249@{chromium#171} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}

Removed a bad word from the enum description

1b4a5fa

In the description of enum "NodeFlags" there is a bad word used, its definitely a misspelling. So corrected a minor mistake in this description.

avighnac approved these changes Jun 5, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed a Bad word / misspelling from the enum description in Blink/node.h #171

Removed a Bad word / misspelling from the enum description in Blink/node.h #171

YogeshTembe commented May 19, 2023

google-cla bot commented May 19, 2023

Jsm34 commented May 28, 2023

Removed a Bad word / misspelling from the enum description in Blink/node.h #171

Are you sure you want to change the base?

Removed a Bad word / misspelling from the enum description in Blink/node.h #171

Conversation

YogeshTembe commented May 19, 2023

google-cla bot commented May 19, 2023

Jsm34 commented May 28, 2023