Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 0.4.x msrv ci issue #1003

Closed
wants to merge 3 commits into from
Closed

Merge 0.4.x msrv ci issue #1003

wants to merge 3 commits into from

Conversation

esheppa
Copy link
Collaborator

@esheppa esheppa commented Mar 30, 2023

My intention here is to bring across the CI fix, but having looked into more detail at 1f1e2f8 I think that there may be some possibility to bring some or all of that work into 0.5 which is using windows-sys instead, so perhaps its better for this not to be merged for now. Question is, should that work be done in the merge here, or in a seperate PR directly to main?

@djc
Copy link
Contributor

djc commented Mar 30, 2023

I think it makes sense to merge this work here. But mostly, for the MSRV issues, I'd like your feedback on #995.

There have been some developments on the windows side where I think we might want to use windows-bindgen instead of windows-sys going forward.

@kennykerr
Copy link
Contributor

I don't recommend using windows-bindgen directly. I think your best bet is to stick with windows-sys.

https://kennykerr.ca/rust-getting-started/standalone-code-generation.html

@pitdicker
Copy link
Collaborator

Now that the MSRV is raised to 1.56 in #1053 we would no longer need a workaround.

@esheppa
Copy link
Collaborator Author

esheppa commented May 13, 2023

That is a good point @pitdicker - and as the MSRV now exceeds 1.48 everywhere, we can use the same impl for offset/local/windows.rs in both 0.4.x and main.

@pitdicker
Copy link
Collaborator

I opened #1190 for the suggestion to switch to windows-sys like on main.

@pitdicker pitdicker closed this Jul 17, 2023
@pitdicker pitdicker deleted the merge-0.4.x-msrv-ci-issue branch July 17, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants