Backport #1285: Add TimeZone::timestamp_micros
#1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2023 10:12
NaiveDateTime::from_timestamp_millis to reduce code duplication
Use NaiveDateTime::from_timestamp_micros instead of implementing the same logic again.
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1293 +/- ##
==========================================
- Coverage 91.33% 91.33% -0.01%
==========================================
Files 38 38
Lines 16971 16990 +19
==========================================
+ Hits 15501 15518 +17
- Misses 1470 1472 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fault, I should have noticed #1285 bas targeting main instead of 0.4.x.