Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iana-time-zone to 0.1.44 #774

Closed
wants to merge 1 commit into from
Closed

Update iana-time-zone to 0.1.44 #774

wants to merge 1 commit into from

Conversation

Kijewski
Copy link
Contributor

The circular dependency problems mentioned in #770 (comment) where fixed in iana-time-zone 0.1.44. iana-time-zone now depends on core-foundation-sys instead of core-foundation.

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that we can't reintroduce it?

The circular dependency problems mentioned in
<#770 (comment)>
where fixed in `iana-time-zone` 0.1.44. `iana-time-zone` now depends on
`core-foundation-sys` instead of `core-foundation`.
@djc
Copy link
Contributor

djc commented Aug 12, 2022

See #773, though I guess maybe I got the version wrong?

@Kijewski
Copy link
Contributor Author

I had this as open PR against trevor-crypto:iana-sgx, but it was not picked in time. :-/ I guess I did not press F5 before updating my commit, and didn't see #773 before opening this PR.

#773 uses the correct version.

@Kijewski Kijewski closed this Aug 12, 2022
@djc
Copy link
Contributor

djc commented Aug 12, 2022

Well, like I said in that PR, it doesn't belong there anyway.

I fixed #773 to use the right version. Thanks for helping out with all this!

@Kijewski
Copy link
Contributor Author

You're welcome! Fun fact: Even before this problem, I added SGX as the prime example for a target, that is not implemented in iana-time-zone. :) strawlab/iana-time-zone@5edaf34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants