Added typescript eslint packages as peer dependencies

chungweileong94 · Oct 8, 2020 · 29a794c · 29a794c
1 parent 4491e5e
commit 29a794c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/base/package.json b/base/package.json
@@ -43,4 +43,4 @@
     "@typescript-eslint/parser": "^4.4.0",
     "typescript": "^4.0.3"
   }
-}
+}
diff --git a/dependencies.js b/dependencies.js
@@ -9,9 +9,7 @@ const PACKAGE_PATHS = [
     path: './base/package.json'
   },
   {
-    path: './react/package.json',
-    // eslint-config-react-app came with another version
-    ignorePackages: ['@typescript-eslint/eslint-plugin', '@typescript-eslint/parser']
+    path: './react/package.json'
   }
 ];
 

diff --git a/react/package.json b/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-whiteroom-react",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "White Room (React) Eslint Configuration",
   "author": "Chung Wei <leongchungwei@hotmail.com>",
   "repository": {
@@ -28,7 +28,9 @@
     "eslint-plugin-prettier": "^3.1.4",
     "prettier": "^2.1.2",
     "eslint-config-prettier": "^6.12.0",
-    "typescript": "^4.0.3"
+    "typescript": "^4.0.3",
+    "@typescript-eslint/eslint-plugin": "^4.4.0",
+    "@typescript-eslint/parser": "^4.4.0"
   },
   "peerDependencies": {
     "eslint": "^5.16.0 || ^6.7.2",
@@ -43,6 +45,8 @@
     "eslint-plugin-prettier": "^3.1.4",
     "prettier": "^2.1.2",
     "eslint-config-prettier": "^6.12.0",
-    "typescript": "^4.0.3"
+    "typescript": "^4.0.3",
+    "@typescript-eslint/eslint-plugin": "^4.4.0",
+    "@typescript-eslint/parser": "^4.4.0"
   }
 }
diff --git a/react/rules/typescript.js b/react/rules/typescript.js
@@ -7,7 +7,6 @@ module.exports = {
         warnOnUnsupportedTypeScriptVersion: true
       },
       rules: {
-        '@typescript-eslint/explicit-function-return-type': 'off',
         'react/prop-types': 'off'
       }
     }