Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/select dataset for each scenario in campaign #84

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Feat/select dataset for each scenario in campaign #84

merged 6 commits into from
Jun 3, 2024

Conversation

DelaunayAlex
Copy link
Contributor

No description provided.

@DelaunayAlex DelaunayAlex self-assigned this May 17, 2024
@DelaunayAlex DelaunayAlex added the enhancement New feature or request label May 17, 2024
@DelaunayAlex DelaunayAlex force-pushed the feat/select_dataset_for_each_scenario_in_campaign branch from a4489d6 to 8682d91 Compare May 22, 2024 16:14
@DelaunayAlex DelaunayAlex changed the title [WIP] Feat/select dataset for each scenario in campaign Feat/select dataset for each scenario in campaign May 22, 2024
nbrouand
nbrouand requested changes May 24, 2024
View reviewed changes
Copy link
Member

@nbrouand nbrouand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do not show dataset column if there are no dataset on the instance
  • Add a padding on rigth side of the right table
  • Do not allow to save two scenario with same dataset (or no dataset). Add an error message
  • You removed the tag features on the filter combo box

nbrouand
nbrouand reviewed May 27, 2024
View reviewed changes
Copy link
Member

@nbrouand nbrouand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue when drag/drop, sometimes lines switch

chutney/ui/src/app/modules/campaign/components/create-campaign/campaign-edition.component.ts Show resolved Hide resolved
@nbrouand nbrouand merged commit aee8053 into main Jun 3, 2024
2 checks passed
@nbrouand nbrouand deleted the feat/select_dataset_for_each_scenario_in_campaign branch June 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarimGl KarimGl KarimGl left review comments

@boddissattva boddissattva boddissattva left review comments

@nbrouand nbrouand nbrouand approved these changes

Assignees

@DelaunayAlex DelaunayAlex

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DelaunayAlex @nbrouand @KarimGl @boddissattva